feat(CK Board): Log out of CK Board when user logs out of SCORE #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelWiebe
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
LGTM
I was able to successfully log out in both directions (SCORE logs out the CK Board and CK Board logs out SCORE). In both cases it was not immediately apparent that the session had expired for the partner app but after clicking on links or refreshing the page then I was redirected to the login page. Perhaps (in the future) each app can handle the expired/ended session by redirecting the user more immediately to the login page?
Once again, looks great! I think we're good to merge.
hirokiterashima
pushed a commit
that referenced
this pull request
Apr 21, 2023
hirokiterashima
pushed a commit
that referenced
this pull request
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When a user signs out of SCORE, we also sign out of CK Board.
Test
Test with the ck-board branch from this PR
src/main/resources/application-dockerdev.propertiesfile by adding this new property below. Replace192.168.86.29with your local IP.Start up SCORE, ck-board frontend, and ck-board backend.
Sign in to SCORE.
Open CK Board in a new tab. You should be automatically logged in.
Sign out of SCORE.
Go to the CK Board tab and refresh it. You should be logged out of CK Board and it should redirect you to the sign in page.
Closes #7