Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golang bucket refs for upload/download URLs. #1727

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix golang bucket refs for upload/download URLs. #1727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions runtimes/go/storage/objects/refs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ type BucketPerms interface {
// all the read-write permissions.
type ReadWriter interface {
Uploader
SignedUploader
Downloader
SignedDownloader
Remover
Expand Down Expand Up @@ -57,7 +58,7 @@ type Uploader interface {
type SignedUploader interface {
// SignedUploadURL returns a signed URL that can be used to upload directly to
// storage, without any other authentication.
SignedUploadURL(ctx context.Context, object string, options ...UploadURLOption) (string, error)
SignedUploadURL(ctx context.Context, object string, options ...UploadURLOption) (*SignedUploadURL, error)

perms()
}
Expand Down Expand Up @@ -97,7 +98,7 @@ type Downloader interface {
type SignedDownloader interface {
// SignedDownloadURL returns a signed URL that can be used to download directly
// from storage, without any other authentication.
SignedDownloadURL(ctx context.Context, object string, options ...DownloadURLOption) (string, error)
SignedDownloadURL(ctx context.Context, object string, options ...DownloadURLOption) (*SignedDownloadURL, error)

perms()
}
Expand Down
Loading