encointer v0.8.0 #268

clangenb · 2022-01-09T14:24:10Z

Tested:

Successful meetup including claiming of community income. Which is currently just a big button on the homepage, as the UI will be adjusted anyhow.
Tested registering with proof of attendance.
Tested community currency transfer.

clangenb · 2022-01-09T14:26:39Z

lib/js_service_encointer/src/service/encointer.js

-export async function subscribeParticipantIndex (msgChannel, cid, cIndex, address) {
-  return await api.query.encointerCeremonies.participantIndex([cid, cIndex], address, (value) => {
-    send(msgChannel, value);
-  }).then((unsub) => unsubscribe(unsub, msgChannel));
-}
-


Subscribing to this is no longer supported out of the box, as we have need to query 4 different registries for the participant index. Currently, we only fetch actively from the dart side.

clangenb · 2022-01-09T14:27:18Z

lib/js_service_encointer/src/service/encointer.js

-  return pIndex;
-}
-
-export async function getParticipantCount (cid, cIndex) {


Removed participantCount; it was not used anywhere.

Well, it would be nice to show, actually. "you are not alone"

Added to the list encointer/encointer-js#40

clangenb · 2022-01-09T14:32:24Z

lib/page/assets/index.dart

@@ -516,10 +535,37 @@ class _AssetsState extends State<Assets> {
                  );
          },
        ),
+        FutureBuilder<bool>(


Only display a big button on the main-page. I did not bother at all about the UX here because we are amidst heavy changes.

[JS + Dart] remove unused participantCount state and getters [JS + Dart] remove subscribeParticipantIndex, which does no longer exist. [Dart] fix getMeetupLocation [JS] extract locationFromJson function add `hasPendingIssuance` and display in assets page if we have pending issuance. [assets] successfully claim rewards. [types] change all fields to camelCase, as this has bin changed in polkadot-js [types] rename fields meetupLocationIndex -> meetupIndex [GA] use latest encointer-node artifact. [JS] fix tests

…ance.

…to fix putting it into the txlist too.

… page via Assets

…-fee estimation is displayed on the tx-detail page.

clangenb · 2022-01-11T16:50:27Z

README.md

-
-Re-generate mobx g.dart files
-  flutter packages pub run build_runner build --delete-conflicting-outputs



Redundant info: this is displayed10 lines below, too.

clangenb · 2022-01-11T16:51:23Z

lib/js_service_encointer/src/service/account.js

@@ -302,50 +303,6 @@ function isTcIsRegisterAttestations (txInfo) {
  return TrustedCallMap[txInfo.module][txInfo.call] === 'ceremonies_register_attestations';
 }

-function _extractEvents (api, result) {


Outsourced to @encointer

clangenb · 2022-01-11T17:01:18Z

lib/js_service_encointer/src/service/encointer.js

-  return pIndex;
-}
-
-export async function getParticipantCount (cid, cIndex) {


Added to the list encointer/encointer-js#40

clangenb · 2022-01-11T17:05:58Z

lib/page/assets/index.dart

                      iconData: Icons.upload_sharp,
                      onTap: store.encointer.communityBalance != null
                          ? () {
                              Navigator.pushNamed(
                                context,
                                TransferPage.route,
                                arguments: TransferPageParams(
-                                    redirect: AssetPage.route,
+                                    redirect: '/',


The app crashed before because we do no longer go from the asset page to transfer page, but from the home page after the UX change.

clangenb · 2022-01-11T17:07:15Z

lib/page/assets/index.dart

+          Observer(builder: (_) {
+            var dic = I18n.of(context).assets;
+
+            return store.settings.isConnected


Big fat button that does show whether the community income can be issued or not. I wasn't concerned about the UX at all for now, as we are changing things heavily currently.

clangenb · 2022-01-11T17:08:08Z

lib/page/assets/transfer/transferPage.dart

-                        Padding(
-                          padding: const EdgeInsets.fromLTRB(8.0, 16, 8, 72),
-                          child: Center(
-                            child: Text('transactionByteFee: ${store.settings.transactionByteFee} $baseTokenSymbolView',
-                                style: TextStyle(fontSize: 16, color: Colors.black54)),
-                          ),
-                        ),


Remove the transaction-byte-fee because we show the more meaningful tx-fee-estimate on the next page anyhow.

clangenb · 2022-01-11T17:11:45Z

lib/store/encointer/encointer.dart

+        "token": isCommunityCurrency
+            ? CommunityIdentifier.fromJson(i['params'][1]).toFmtString()
+            : rootStore.settings.networkState.tokenSymbol,


We store the txs in the 'sent tx list', which does not allow anything else than a string for the token, but in the tx callback the JS crashed before, which is why this error was not noticed.

clangenb · 2022-01-11T17:13:35Z

lib/page/assets/transfer/transferPage.dart

-        // user may route to transfer page from asset page
-        // or from home page with QRCode Scanner
-        if (routeArgs.redirect == AssetPage.route) {
-          globalAssetRefreshKey.currentState.show();
-        }


No longer true, we can only go there from the home page

brenzi

I tested a local setup with the current node master
Was able to connect and register participant
In the logs I only saw:

I/flutter ( 3162): Image.network error: SocketException: OS Error: Connection refused, errno = 111, address = 10.0.2.2, port = 56466

not sure what this is about. but it doesn't seem to disturb

clangenb · 2022-01-14T08:00:35Z

The error is from the IPFS community icon fetch. With the encointer-dev nework ipfs defaults to the local host. When there is no ipfs-node running this fails, and then it defaults to the current encointer icon.

clangenb commented Jan 9, 2022

View reviewed changes

clangenb force-pushed the cl/encointer-v0.8.0 branch from d3dd289 to d3f2452 Compare January 11, 2022 09:23

clangenb added 2 commits January 11, 2022 10:25

rebase fixes

6998958

clangenb force-pushed the cl/encointer-v0.8.0 branch from d3f2452 to 6998958 Compare January 11, 2022 11:06

clangenb added 14 commits January 11, 2022 12:15

[store/settings] remove obsolete todo

8ff1560

[Readme] remove redundant comment about generated files

6cc4fdc

[store/settings] introduce computed isConnected

079e695

[assets] wait for being connected fect information about pending issu…

2c854e3

…ance.

[assets] remove obsolete pending issuance wrapper

31f96b3

[assets] replace pending income text with i18n

a4abfdf

[transfer] fix returning balance type from community transfer. (need …

85913f1

…to fix putting it into the txlist too.

[transfer] fix putting community transfer into the txlist.

4763a78

fix some docs

048b49b

[transfer] fix redirect after sending tx. We no longer go to transfer…

2259c5f

… page via Assets

[transferPage] remove transaction byte fee, as the more meaningful tx…

33e70bb

…-fee estimation is displayed on the tx-detail page.

flutter fmt

f0b8f4e

fix flutter analyze

8929111

fix docs

aa2baf5

clangenb commented Jan 11, 2022

View reviewed changes

fix integration tests by remove call to unknown gesell rpc

49ed867

clangenb requested a review from brenzi January 11, 2022 18:59

brenzi approved these changes Jan 12, 2022

View reviewed changes

clangenb merged commit df1d4e3 into master Jan 14, 2022

clangenb mentioned this pull request Jan 14, 2022

bump to encointer v0.8.0 #246

Closed

4 tasks

clangenb deleted the cl/encointer-v0.8.0 branch January 22, 2022 08:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

encointer v0.8.0 #268

encointer v0.8.0 #268

clangenb commented Jan 9, 2022 •

edited

Loading

clangenb Jan 9, 2022

clangenb Jan 9, 2022

brenzi Jan 10, 2022

clangenb Jan 11, 2022

clangenb Jan 9, 2022

clangenb Jan 11, 2022 •

edited

Loading

clangenb Jan 11, 2022

clangenb Jan 11, 2022

clangenb Jan 11, 2022

clangenb Jan 11, 2022

clangenb Jan 11, 2022

clangenb Jan 11, 2022

clangenb Jan 11, 2022

brenzi left a comment

clangenb commented Jan 14, 2022


		Re-generate mobx g.dart files
		flutter packages pub run build_runner build --delete-conflicting-outputs

encointer v0.8.0 #268

encointer v0.8.0 #268

Conversation

clangenb commented Jan 9, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

clangenb Jan 11, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brenzi left a comment

Choose a reason for hiding this comment

clangenb commented Jan 14, 2022

clangenb commented Jan 9, 2022 •

edited

Loading

clangenb Jan 11, 2022 •

edited

Loading