Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pimp cli #363

Merged
merged 10 commits into from
Mar 20, 2024
Merged

pimp cli #363

merged 10 commits into from
Mar 20, 2024

Conversation

brenzi
Copy link
Member

@brenzi brenzi commented Mar 19, 2024

closes #282

  • make client work with pre-migration Reputation type
  • make use of --at argument for all queries which can work without custom rpc (where block can't be specified)
  • make stout parsable as CSV for list-participants, list-meetups, list-attestees

@brenzi brenzi requested a review from clangenb March 20, 2024 07:50
Comment on lines +47 to +49
if maybe_at.is_some() {
panic!("can't apply --at if --cid not set")
};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be tricky to support --at here because we make heavy use of custom rpc's

Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny question, looks good otherwise. I guess you did test it already. :)

client/src/commands/encointer_ceremonies.rs Show resolved Hide resolved
@brenzi brenzi merged commit 7db756e into master Mar 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client shall support --atBlock arg for various cmds.
2 participants