Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to polkadot v1.8.0 #361

Merged
merged 41 commits into from
Mar 6, 2024
Merged

upgrade to polkadot v1.8.0 #361

merged 41 commits into from
Mar 6, 2024

Conversation

brenzi
Copy link
Member

@brenzi brenzi commented Mar 1, 2024

  • upgrade all polkadot-sdk dependencies to 1.8.0 off crates.io
  • adapt versioning scheme to follow polkadot-sdk with major.minor to be consistent with parachain node
  • major refactoring of cli to async
    • only "made it work". didn't optimize for performance yet but there's plenty of potential now to join async ops which don't need to be sequential
    • modularized commands. also here, this is likely only the first step towards a more convenient and maintainable codebase
  • upgrade to substrate-api-client 0.17.0. needed to use a patch branch, see
  • builds in stable (fmt still uses nightly, because stable sucks. fellows runtimes does the same)

@brenzi brenzi marked this pull request as ready for review March 5, 2024 15:18
@brenzi brenzi requested a review from clangenb March 5, 2024 17:09
@brenzi
Copy link
Member Author

brenzi commented Mar 5, 2024

CI test bootstrap.. currently fails upon querying fee details:

node:

2024-03-05 18:08:48.028 ERROR tokio-runtime-worker runtime: panicked at /home/brenzi/encointer/encointer-node/runtime/src/lib.rs:637:1:
Bad input data provided to query_fee_details: Codec error    

client:

thread 'main' panicked at client/src/commands/encointer_core.rs:271:10:
Could not query asset fee details: Client(Call(ErrorObject { code: ServerError(1), message: "Unable to query fee details.", data: Some(RawValue("Execution failed: Execution aborted due to trap: wasm trap: wasm `unreachable` instruction executed\nWASM backtrace:\nerror while executing at wasm backtrace:\n    0: 0x19c207 - <unknown>!rust_begin_unwind\n    1: 0x87b8 - <unknown>!core::panicking::panic_fmt::hd76cc5a8b1843eaf\n    2: 0x13a198 - <unknown>!TransactionPaymentApi_query_fee_details")) }))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

guess this is the first attempt to pay fees in CC

@clangenb
Copy link
Member

clangenb commented Mar 6, 2024

Hmmm, this line panicks as it seems: https://github.com/encointer/pallets/blob/79c7f85e45d72a417918a7d5297db1cb0001dcbe/balances-tx-payment/rpc/src/lib.rs#L100

Not sure if it has to do something with the different runtime api versions define here, but the last update to this file is quite old, so I don't think it should matter: https://github.com/paritytech/polkadot-sdk/blob/329c07723614836a05b1d9158e1a8fdea6fb6508/substrate/frame/transaction-payment/rpc/runtime-api/src/lib.rs.

@brenzi
Copy link
Member Author

brenzi commented Mar 6, 2024

hmm, this here works, so I doubt we have a general issue here:
../target/release/encointer-client-notee transfer //Alice //Dave 0.123 --cid sqm1v79dF6b --tx-payment-cid sqm1v79dF6b

it's the whitelist argument which causes the trouble. This here reproduces the issue:
../target/release/encointer-client-notee transfer //Alice //Dave 0.123 sqm1v79dF6b --cid sqm1v79dF6b --tx-payment-cid sqm1v79dF6b

ah, I messed up the whitelist argument and dropped the option wrapper

@brenzi brenzi merged commit 50fed3b into master Mar 6, 2024
13 checks passed
@brenzi brenzi mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants