-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update api-client to tag v0.12 #328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, sorry I was curious, and I already had to take a look at it. :) Looks like a nice improvement in general. :)
If an extrinsic fails the following is now printed:
Previously:
@clangenb is that enough information? |
Yes, for now, this is absolutely fine. We could find the error based on the metadata, but this shall be an extra step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful. Thanks for this very quick implementation!
If so, this function might be interesting for you: https://github.com/scs/substrate-api-client/blob/f11729e8d86e9c15ad891069b1a2f64d0ab0deb8/src/api/rpc_api/events.rs#L126 |
Absolutely! #329 |
closes #319