Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add session proxy calls and getters to worker-api #125

Merged
merged 15 commits into from
Dec 12, 2024
Merged

Conversation

brenzi
Copy link
Member

@brenzi brenzi commented Dec 1, 2024

closes #124

TrustedCall

  • sendNote
  • addSessionProxy

TrustedGetter

  • accountInfoAndSessionProxies

other functionality

  • signing must support delegate on behalf of account

Comment on lines +96 to +100
expect(result).toBeDefined();
const info = result as AccountInfo;
console.log("parsed: ", info.data.free);
// we don't forward errors here. instead, failures are mapped to default, which is zero
expect(info.data.free.toBigInt()).toEqual(BigInt(0));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toBeDefined is used too often IMHO. It says almost nothing about success

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I did this as I wanted to test it against a running setup that might return different results for sequential runs.

@brenzi brenzi merged commit 0c9a088 into master Dec 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[worker-api] add session proxy calls and getters
2 participants