Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullet-proof string to fixed-point conversion, is it needed? #35

Open
clangenb opened this issue Dec 21, 2021 · 0 comments
Open

Bullet-proof string to fixed-point conversion, is it needed? #35

clangenb opened this issue Dec 21, 2021 · 0 comments

Comments

@clangenb
Copy link
Member

In the conversion from string to fixed-point values, we parse the string to a float. In theory, this can be inconsistent.

The runtime validates the locations in the attestations exactly. So if a discrepancy occurs, the attestation is invalid. So far, this has not been observed.

The question is whether we care about an exact transform, or if we just allow for slight discrepancies when validating the fixed point number in the location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant