Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community choser pins not accurately placed on seed location #370

Closed
brenzi opened this issue Feb 17, 2022 · 3 comments
Closed

community choser pins not accurately placed on seed location #370

brenzi opened this issue Feb 17, 2022 · 3 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@brenzi
Copy link
Member

brenzi commented Feb 17, 2022

Gesell has a community with one location:

~/encointer-client-notee list-locations --cid u0qj95PYNyD
listing locations for cid u0qj95PYNyD
lat: 47.3895147567476087147 lon: 8.5170140862464904785

here's where that should be:

https://www.google.ch/maps/place/47%C2%B023'22.3%22N+8%C2%B031'01.3%22E/@47.3895148,8.5148254,17z/data=!3m1!4b1!4m5!3m4!1s0x0:0xee1e99f8f6bccbaa!8m2!3d47.3895148!4d8.5170141

But the app shows it rather here:
https://www.google.ch/maps/place/47%C2%B023'22.3%22N+8%C2%B031'01.3%22E/@47.3950364,8.5034611,20.75z/data=!4m5!3m4!1s0x0:0xee1e99f8f6bccbaa!8m2!3d47.3895148!4d8.5170141

@brenzi brenzi added the bug Something isn't working label Feb 17, 2022
@brenzi
Copy link
Member Author

brenzi commented Feb 17, 2022

@clangenb could this be conversion errors? encointer/encointer-js#35

@clangenb
Copy link
Member

Hmm, this would surprise me. If we look at the numbers:

47.3895148 8.5148254,17 vs:
47.3950364 8.5034611,20.75

This should be too much of a difference for just a floating-point discrepancy

@brenzi
Copy link
Member Author

brenzi commented Feb 23, 2022

this is caused by the fact that we derive the location from the cid geohash, which would be good enough (as it points to Zurich)

So this is actually a wontfix. We'd better avoid too close communities

@brenzi brenzi added the wontfix This will not be worked on label Feb 23, 2022
@brenzi brenzi changed the title community choser misplaces pins community choser pins not accurately placed on seed location Feb 23, 2022
@brenzi brenzi closed this as completed Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants