Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assigment to meetups #34

Merged
merged 11 commits into from
Jan 25, 2023
Merged

Assigment to meetups #34

merged 11 commits into from
Jan 25, 2023

Conversation

echevrier
Copy link
Collaborator

@echevrier echevrier commented Jan 23, 2023 •
edited
Loading

The assignments to meetups occur automatically when the ceremony phase is Assigning. For a private community, the assisgnments are confidential and are executed on the sidechain.

  • migration of a public community to private to update at once all required communities pallet's storage : command make-community-private

    • The Locations are fetched from the node over an jsonrpc call
    • Only the identifiers of private communities are on the sidechain.
    • Participant registration can only be done on the sidechain for a private community

  • The assigments can be checked with the list-meetups command. This is implemented according to the encointer-node command.

    • requested public and private getters were added
    • logic to generate the ceremony statistic is implement in the cli.

  • The demo_private-community script can be used to run the different steps.

echevrier added 5 commits January 19, 2023 10:44
1. Draft cto test assignments in enclave. Some features are still mis…
f031f29 
…sing, but it seems to work. Important steps required:

- update of required param in communities pallet -> ceremonies_migrate_to_private_community
- Locations: get from node over json req and updated with a trusted call to the communities pallet
- list-meetup command to check the results
simplify meetup participants
0309e82
improve private community:
badb30c 
- add the community identifier in the private community pallet during migration
- update communities storage only during the migration
- add check
Clippy
e61dee1
Commit cargo changes
8b4e321 
Clean log messages
Add demo file for private community
@echevrier echevrier added A0-core Affects core part (According to integritee worker) A1-cli Affects cli functionalites (According to integritee worker) A2-applibs Affects app-libs, i.e. runtime or stf (According to integritee worker) B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing labels Jan 23, 2023
@echevrier echevrier requested a review from clangenb January 24, 2023 08:57
clangenb
clangenb reviewed Jan 24, 2023
View reviewed changes
Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice in general, this looks very much like I expected. I only have some minor comments, and suggestions for the future, which should not be done now.

cli/src/trusted_commands.rs Outdated Show resolved Hide resolved
app-libs/stf/src/getter.rs Show resolved Hide resolved
app-libs/stf/src/getter.rs Outdated Show resolved Hide resolved
app-libs/stf/src/encointer_helpers.rs Show resolved Hide resolved
cli/demo_private_community.sh Show resolved Hide resolved
cli/src/ceremonies/commands/ceremonies_command_utils.rs Outdated Show resolved Hide resolved
app-libs/stf/src/trusted_call.rs Show resolved Hide resolved
core-primitives/node-api/api-client-extensions/src/encointer.rs Show resolved Hide resolved
@echevrier echevrier requested a review from clangenb January 25, 2023 15:57
clangenb
clangenb approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good to me now!

@echevrier echevrier merged commit f3e730d into main Jan 25, 2023
@echevrier echevrier deleted the ec/list-meetups branch January 25, 2023 17:21
This was referenced Feb 27, 2023
Closed
Closed
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

Assignees
No one assigned
Labels
A0-core Affects core part (According to integritee worker) A1-cli Affects cli functionalites (According to integritee worker) A2-applibs Affects app-libs, i.e. runtime or stf (According to integritee worker) B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echevrier @clangenb