Skip to content

Commit

Permalink
chore: fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jacky-xbb authored and Rory-Z committed Sep 14, 2023
1 parent bff1255 commit 6c8cb10
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 13 deletions.
18 changes: 7 additions & 11 deletions config/grafana-template/grafanalib-emqx/README.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
# grafanalib-emqx


## Setup

Usage of Python 3 is required. It can be installed [on Python.org](https://www.python.org/downloads/)


- Install Pipenv

```shell
Expand All @@ -23,21 +24,16 @@ pipenv install
pipenv shell
```


## Generate Dashboard JSON

- Install Enterprise Dashboard
- Install EMQX Enterprise Dashboard

```shell
./emqx5.py > emqx5.json
./emqx5.py -e ee > emqx5.json
```

- Install OpenSource Dashboard
- Install EMQX Community Edition Dashboard

```
./emqx5.py -c os > emqx5.json
./emqx5.py -e ce > emqx5.json
```




4 changes: 2 additions & 2 deletions config/grafana-template/grafanalib-emqx/emqx5.py
Original file line number Diff line number Diff line change
Expand Up @@ -421,11 +421,11 @@ def generate_table_overrides(targets):
parser = argparse.ArgumentParser(description="Argument Parser")

# Define a single optional argument for category (-c or --category)
parser.add_argument("-c", "--category", choices=["ee", "os"], help="Set EMQX Enterprise(ee) or EMQX OpenSource(os)")
parser.add_argument("-e", "--edition", choices=["ee", "ce"], help="Set EMQX Enterprise(ee) or EMQX Community(ce)")

args = parser.parse_args()

if args.category == "os":
if args.edition == "ce":
is_ee = False

# create a dashboard
Expand Down

0 comments on commit 6c8cb10

Please sign in to comment.