Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): adapt new field access_method in S3 #3063

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

Kinplemelon
Copy link
Member

@Kinplemelon Kinplemelon commented Nov 21, 2024

https://emqx.atlassian.net/browse/ED-1679

This new configuration, I'm not sure if it's correct to put it here, please confirm
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
image

@emqxqa
Copy link

emqxqa commented Nov 21, 2024

TestExecution

@Kinplemelon Kinplemelon removed the request for review from ysfscream November 21, 2024 03:14
@Kinplemelon Kinplemelon marked this pull request as draft November 21, 2024 03:14
@Kinplemelon Kinplemelon marked this pull request as ready for review November 21, 2024 07:06
@ysfscream
Copy link
Member

This new configuration, I'm not sure if it's correct to put it here, please confirm

No worry just put it here first. Fine with me.

@ysfscream ysfscream merged commit 4699a1d into enterprise Nov 22, 2024
5 checks passed
@ysfscream ysfscream deleted the kinple/s3-new-field branch November 22, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants