Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base Env test cases #188

Merged
merged 19 commits into from
Dec 10, 2024
Merged

Base Env test cases #188

merged 19 commits into from
Dec 10, 2024

Conversation

thisjustin123
Copy link
Collaborator

@thisjustin123 thisjustin123 commented Dec 9, 2024

Description:

Adds new test cases for the base_env class's functions.

Functions Tested:

  • InstanceObject(), ClearScene(), and LoadSceneAsync() are tested by test_save_and_load(). I guess this also technically tests PreLoadAssetsAsync().
  • SendObject() and AddListenerObject() are tested by test_object_listener()
  • LoadURDF(), LoadCloth(), LoadMesh() are tested by test_load_objects(). To get this to pass, I needed to have the GitHub Actions run sudo apt-get install libminizip1; not sure why.

@thisjustin123 thisjustin123 linked an issue Dec 9, 2024 that may be closed by this pull request
@thisjustin123 thisjustin123 marked this pull request as ready for review December 9, 2024 19:12
@thisjustin123 thisjustin123 changed the title [WIP] Env test cases Env test cases Dec 9, 2024
@thisjustin123 thisjustin123 changed the title Env test cases Base Env test cases Dec 9, 2024
Copy link
Member

@YoruCathy YoruCathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a line in the install instruction telling users they might need libminizip1 on their local environments if the scene APIs are not working?

@thisjustin123
Copy link
Collaborator Author

Just updated the readme to add this as a pre-install instruction!

Copy link
Member

@YoruCathy YoruCathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge.

@YoruCathy YoruCathy merged commit 36ffbec into phy-robo-care Dec 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to load saved scenes
2 participants