Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename notebooks in a progressive order #206

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Rename notebooks in a progressive order #206

wants to merge 10 commits into from

Conversation

edoardob90
Copy link
Member

Fixes #81

@edoardob90 edoardob90 linked an issue Mar 7, 2024 that may be closed by this pull request
Naming: enumerate notebooks #81
Open
@edoardob90 edoardob90 requested a review from despadam March 27, 2024 16:22
@edoardob90
Copy link
Member Author

I think we can merge this one as well. It's just renaming.

@despadam I double-checked again the internal links. They seem to work properly. If you want, you can have a look. If something is not working, we can fix it later with a new PR.

@despadam despadam added the upcoming tutorial Stuff to work on/fix before the next tutorial label Mar 28, 2024
@despadam
Copy link
Contributor

@edoardob90 overall looks good! Only needs a couple of fixes and a few cosmetic changes.

despadam
despadam requested changes Mar 28, 2024
View reviewed changes
04-input_output.ipynb Outdated Show resolved Hide resolved
06-modules_and_packages.ipynb Outdated Show resolved Hide resolved
00-intro.ipynb Outdated Show resolved Hide resolved
11-functional_programming.ipynb Outdated Show resolved Hide resolved
slides/control_flow_slides.ipynb Outdated Show resolved Hide resolved
slides/functions_slides.ipynb Outdated Show resolved Hide resolved
@despadam
Copy link
Contributor

despadam commented May 2, 2024

Will cover the rest of the suggestions in a separate PR

@despadam
Copy link
Contributor

despadam commented May 2, 2024

See #226

@despadam despadam added enhancement New feature or request and removed upcoming tutorial Stuff to work on/fix before the next tutorial labels May 3, 2024
@despadam despadam marked this pull request as draft May 3, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@despadam despadam despadam requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Naming: enumerate notebooks
2 participants
@edoardob90 @despadam