Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards full Python interface to the C core of CLEED #44

Merged
merged 6 commits into from
Jul 25, 2024

Conversation

yakutovicha
Copy link
Member

@yakutovicha yakutovicha commented Jan 15, 2024

fixes #12

  1. New cmdline script called cleedpy-leed and provide initial implementation.
  2. Small modifications to the config module.
  3. Provide preprocess module to prepare the inputs.
  4. Move mk_cg_coef and mk_ylm_coef functions from test_cleed.c to leed.c.
  5. Provide a working example of yaml input for the code.

1. New cmdline script called `cleedpy-leed` and provide initial implementation.
2. Small modifications to the config module.
3. Provide preprocess module to prepare the inputs.
4. Move `mk_cg_coef` and `mk_ylm_coef` functions from test_cleed.c to leed.c.
5. Provide a working example of yaml input for the code.
@yakutovicha yakutovicha marked this pull request as draft January 15, 2024 14:56
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d499ca9) 100.00% compared to head (e694fef) 97.27%.
Report is 1 commits behind head on main.

Files Patch % Lines
cleedpy/config.py 73.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #44      +/-   ##
===========================================
- Coverage   100.00%   97.27%   -2.73%     
===========================================
  Files            8        8              
  Lines          136      147      +11     
===========================================
+ Hits           136      143       +7     
- Misses           0        4       +4     
Flag Coverage Δ
python-3.10 97.27% <73.33%> (-2.73%) ⬇️
python-3.11 97.24% <73.33%> (-2.76%) ⬇️
python-3.12 97.24% <73.33%> (-2.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yakutovicha yakutovicha marked this pull request as ready for review July 25, 2024 11:06
@yakutovicha yakutovicha merged commit 1974fb1 into main Jul 25, 2024
7 checks passed
@yakutovicha yakutovicha deleted the update/move-some-c-functions-to-python branch July 25, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a module consisting of Python functions interfacing the cleed's functions
1 participant