Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a class to manage a global run configuration #37

Merged

Conversation

baffelli
Copy link
Member

@baffelli baffelli commented Jan 10, 2024

fixes #6

Added configuration classes.

@baffelli baffelli linked an issue Jan 10, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0853181) 100.00% compared to head (73c12a2) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #37    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            5         8     +3     
  Lines           22       136   +114     
==========================================
+ Hits            22       136   +114     
Flag Coverage Δ
python-3.10 100.00% <100.00%> (ø)
python-3.11 100.00% <100.00%> (ø)
python-3.12 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baffelli baffelli requested a review from yakutovicha January 10, 2024 13:45
Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions

cleedpy/cli/generate_schema.py Outdated Show resolved Hide resolved
cleedpy/cli/validate_parameters.py Outdated Show resolved Hide resolved
examples/cleed.yml Show resolved Hide resolved
@edoardob90 edoardob90 changed the title 6 implement a class to manage a global run configuration Implement a class to manage a global run configuration Jan 10, 2024
@yakutovicha yakutovicha self-requested a review January 10, 2024 15:28
@yakutovicha yakutovicha merged commit e491c57 into main Jan 10, 2024
8 checks passed
@yakutovicha yakutovicha deleted the 6-implement-a-class-to-manage-a-global-run-configuration branch January 10, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a class to manage a global run configuration
2 participants