Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unicode in stdout and stderr #77

Closed
wants to merge 1 commit into from

Conversation

treyhunner
Copy link

This solution delegates the UTF-8 decoding to xterm.js, which accepts a Uint8Array object representing UTF-8 bytes to its write method (docs here).

Thanks to @pmp-p for helping me realize that xterm.js might be able to do the decoding for us.

@brettcannon
Copy link
Collaborator

The failure is for test_decimal, but I have no clue if it's related.

@treyhunner
Copy link
Author

The failure is for test_decimal, but I have no clue if it's related.

This is for the browser Emscripten and not the Node one, so I don't think it's related. 🤔

I opened python/cpython#91879 on the CPython repo, which includes these changes as well as #78.

@emmatyping
Copy link
Owner

The decimal test is flaking it seems, or at least recently started failing.

@pradyunsg
Copy link

If it's a flaky test, a close-reopen (or a click on the re-run button by a maintainer) to rerun the CI might be enough -- if it passes, that would unblock this PR. :)

@emmatyping
Copy link
Owner

If it's a flaky test, a close-reopen (or a click on the re-run button by a maintainer) to rerun the CI might be enough -- if it passes, that would unblock this PR. :)

True! But it is superseded by python/cpython#91879 anyway, so I'll probably just close this.

@emmatyping emmatyping closed this Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants