Merge pull request #258 from crynobone/fixes-255

Fixes `Slug` field inside tab doesn't work since Nova 4.14.0
eminiarts · Oct 25, 2022 · 8a11cd3 · 8a11cd3
2 parents 68d7630 + a527a91
commit 8a11cd3
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 15 deletions.
diff --git a/.github/workflows/update-assets.yml b/.github/workflows/update-assets.yml
@@ -4,7 +4,6 @@ on:
   workflow_dispatch: 
   push:
     branches: [master]
-  pull_request:
 
 jobs:
   update:

diff --git a/resources/js/components/DetailTabs.vue b/resources/js/components/DetailTabs.vue
@@ -75,11 +75,8 @@ import HasTabs from "../mixins/HasTabs";
 
 export default {
   mixins: [BehavesAsPanel, HasTabs],
-  props: {
-    mode: {
-      type: String,
-      default: 'detail',
-    },
-  }
+  data: () => ({
+    tabMode: 'detail',
+  }),
 };
 </script>
diff --git a/resources/js/components/FormTabs.vue b/resources/js/components/FormTabs.vue
@@ -111,11 +111,8 @@ import HasTabs from "../mixins/HasTabs";
 
 export default {
   mixins: [BehavesAsPanel, HasTabs],
-  props: {
-    mode: {
-      type: String,
-      default: 'form',
-    },
-  }
+  data: () => ({
+    tabMode: 'form',
+  }),
 };
 </script>
diff --git a/resources/js/mixins/HasTabs.js b/resources/js/mixins/HasTabs.js
@@ -109,7 +109,7 @@ export default {
       Nova.store.tabsListenerRegistered = true;
     }
 
-    if (this.mode === 'form') {
+    if (this.tabMode === 'form') {
       this.$watch('validationErrors', (newErrors) => {
         if (newErrors.errors) {
           Object.entries(newErrors.errors).forEach(error => {
@@ -227,7 +227,7 @@ export default {
      */
     getComponentName(field) {
       return field.prefixComponent
-        ? this.mode + '-' + field.component
+        ? this.tabMode + '-' + field.component
         : field.component
     },
-Original file line number
+Diff line change
@@ Expand Up / @@ -4,7 +4,6 @@ on: @@
       workflow_dispatch:
       push:
         branches: [master]
-      pull_request:
     jobs:
       update:
@@ Expand Down @@