Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish from GitHub Actions #264

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Publish from GitHub Actions #264

wants to merge 2 commits into from

Conversation

hiroyuki-sato
Copy link
Member

  • copy .github/workflows/publish.yml from embulk-input-s3
  • Use setup-java and checkout v4 instead of v2.

@hiroyuki-sato hiroyuki-sato requested a review from a team as a code owner August 19, 2024 02:40
@dmikurube
Copy link
Member

Please wait a bit. We'll have to set up secrets for releases, and also to change the versioning/releasing strategy (i.e. set *-SNAPSHOT version on master, and remove it on a detached branch to release).

@hiroyuki-sato
Copy link
Member Author

@dmikurube, Would you like to release a new version? As far as I remember, #259 hasn't been released yet. This PR fixes the one Connecotr/J 8.x issue.

dmikurube
dmikurube reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@dmikurube dmikurube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, forgot about it. We may want to release a new version, but as I commented above :

  1. Secrets/variables are not set (so it wouldn't work)
  2. We'll want to change the versioning/releasing strategy

Can you try (2) when you have time? Then I'll work on (1).

.github/workflows/publish.yml Outdated
printf -- "---\n:rubygems_api_key: ${RUBYGEMS_API_KEY}\n" > $HOME/.gem/credentials
./gradlew --stacktrace publishMavenPublicationToMavenCentralRepository gemPush
env:
ORG_GRADLE_PROJECT_ossrhUsername: ${{ secrets.OSSRH_USERNAME }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recently use vars instead of secrets for username. (See some other repos.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I copied these parts.

https://github.com/embulk/embulk-decoder-bzip2/blob/3783be42c7cedc42c3c73c677f3e50451a4d9b8b/.github/workflows/publish.yml#L24-L27

@hiroyuki-sato
Copy link
Member Author

The CI of changing 5b87aa1 failed due to a problem with SQL Server. I believe the CI error doesn't relate to this change. (I'll try to fix the CI problem on another PR.)
https://github.com/embulk/embulk-input-jdbc/actions/runs/12665494256

@dmikurube
Copy link
Member

Yeah, it does not look related, but we may need to dive into it...

@hiroyuki-sato hiroyuki-sato force-pushed the embulk/publish-github-actions branch from 5b87aa1 to 8286a28 Compare January 8, 2025 07:56
@hiroyuki-sato
Copy link
Member Author

@dmikurube I fixed the SQL server issue on #271, so I changed the base commit to the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmikurube dmikurube dmikurube left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiroyuki-sato @dmikurube