Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite dep tests #1880

Closed
wants to merge 2 commits into from
Closed

Vite dep tests #1880

wants to merge 2 commits into from

Conversation

mansona
Copy link
Member

@mansona mansona commented Apr 15, 2024

This PR is to demonstrate how we want to do vite dependency optimisation tests in the future. We don't want any/much vite-specific infrastructure in our tests and we want to rely on the audit system to make sure that the correct dependencies being built in vite dev mode

TODO

  • update the audit system to be able to load html (and references) across HTTP
  • remove the "async file" implementation from this PR and make sure it uses the new audit system

@mansona mansona marked this pull request as draft April 15, 2024 14:20
@mansona
Copy link
Member Author

mansona commented Apr 15, 2024

The actual audit refactor is happening in https://github.com/embroider-build/embroider/tree/audit-refactor but there is no Pull request yet so I can't link to that 😂

@mansona
Copy link
Member Author

mansona commented Apr 30, 2024

We are building a new test based on the work in #1882 which will be a new PR so I'm closing this now 👍

@mansona mansona closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants