Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruby and ffi gem to support M1 macs #121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mansona
Copy link
Contributor

@mansona mansona commented Mar 30, 2023

After a bit of googling there was some suggestion that I needed to update ruby to at least 2.6.8 (or 2.7.x, there was some conflicting info) and the ffi gem to "a version that supported M1 macs" so I updated it to the latest 👍

I don't really know the ramifications of this because I'm not a Ruby guy, but I ran bundle exec rake test locally and it seemed to work 🤷

@kategengler
Copy link
Member

Updating ffi is no problem, but bumping the Ruby version requires updating the server, so I'm not going to merge this just yet. Can you work off of a branch?

@mansona
Copy link
Contributor Author

mansona commented Mar 30, 2023

Yes I am super-happy to work off a branch (or even just using rvm locally), I was just opening this PR to keep track of changes in case anyone else wanted them 👍

Would you like me to commit the ffi changes in a different branch? would this be helpful or will I just keep them to myself for now?

@kategengler
Copy link
Member

Let's keep them together for now. I'm not sure if updating ffi implies Ruby has to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants