Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sass deprecations #562

Open
wants to merge 3 commits into
base: melsumner/failing-scenarios
Choose a base branch
from
Open

Fix sass deprecations #562

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9617179
fix sass deprecations
MelSumner Oct 31, 2024
7961950
remove unnecessary underscore
MelSumner Oct 31, 2024
62914ad
removed underscore that wasn't needed from app.scss
MelSumner Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions tests/dummy/app/styles/app.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
@import 'variables/variables';
@use 'variables/_variables' as *;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] I don't think the underscore is needed anymore (to have Sass ignore certain files). Is it some form of convention used locally? (I see the other files are "imported/used" without the underscore.

@import 'components/components';
@import 'object-patterns/object-patterns';
@import 'pages/pages';
@import 'typography/typography';
@import 'utilities/utilities';
@use 'components/components';
@use 'object-patterns/object-patterns';
@use 'pages/pages';
@use 'typography/typography';
@use 'utilities/utilities';

html {
font-size: 100%;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] not related to this PR, but I would suggest to move the global declarations in a dedicated file (eg. global.scss and import (@use) it as first item after the variables, before the other files (components, patterns, etc).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestion! I've captured it in a separate issue: #563

Expand Down Expand Up @@ -34,9 +34,6 @@ ul {
background-color: $theme-color__offWhite;
z-index: 1;

.application__header {
}

.application__main-content {
min-width: $min-width__main-content;
}
Expand Down
3 changes: 3 additions & 0 deletions tests/dummy/app/styles/components/_button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
@use '../variables/_variables' as *;


.c-button {
display: flex;
font-size: 1em;
Expand Down
10 changes: 5 additions & 5 deletions tests/dummy/app/styles/components/_components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import 'button';
@import 'image';
@import 'menu-link-item';
@import 'radio-track';
@import 'violations-grid-item';
@use 'button';
@use 'image';
@use 'menu-link-item';
@use 'radio-track';
@use 'violations-grid-item';
2 changes: 2 additions & 0 deletions tests/dummy/app/styles/components/_menu-link-item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use '../variables/_variables' as *;

.c-menu-link-item {
height: 3.25em;
position: relative;
Expand Down
1 change: 1 addition & 0 deletions tests/dummy/app/styles/components/_radio-track.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@use 'sass:math';
@use '../variables/_variables' as *;

$height__radio-selector-track-container: 4rem;
$height__radio-selector-track-circle: $height__radio-selector-track-container *
Expand Down
2 changes: 2 additions & 0 deletions tests/dummy/app/styles/components/_violations-grid-item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use '../variables/_variables' as *;

.c-violations-grid-item {
box-shadow: $box-shadow__card;

Expand Down
2 changes: 2 additions & 0 deletions tests/dummy/app/styles/object-patterns/_content-box.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use '../variables/_variables' as *;

.o-content-box {
box-sizing: border-box;
padding: $padding__content-box;
Expand Down
4 changes: 2 additions & 2 deletions tests/dummy/app/styles/object-patterns/_object-patterns.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
* @see: https://www.google.com/search?q=object+orieinted+css&oq=object+orieinted+css&aqs=chrome..69i57j0l5.3247j0j7&sourceid=chrome&ie=UTF-8
*/

@import 'content-box';
@import 'menu-link';
@use 'content-box';
@use 'menu-link';
2 changes: 1 addition & 1 deletion tests/dummy/app/styles/pages/_pages.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
@import 'violations';
@use 'violations';
2 changes: 2 additions & 0 deletions tests/dummy/app/styles/pages/_violations.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use '../variables/_variables' as *;

$width__grid-item: 24rem;
$height__grid-item: $width__grid-item * 0.55;
$margin__grid-item--vertical: 0.5em;
Expand Down
2 changes: 2 additions & 0 deletions tests/dummy/app/styles/typography/_headings.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use '../variables/_variables' as *;

h1,
h2,
h3,
Expand Down
Loading