-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: check size also on main branch #16
Conversation
Added integration tests for MTEB
Merge in updated
We just had an error on main due to size, but which the tests does not catch
@orionw it seems like the tests and HF doesn't agree. when I check one of the files it also seems fine:
|
I am not entirely sure what the best solution is here. We can reduce the precision further, remove the "languages" the results dict (require changes in results loading to add it back in based on metadata). Lastly (which is probably my suggestion), we can remove unused metrics (e.g. precision). for reference, the inner result dict looks like:
We previously also discussed splitting up the file, which would cause problems with the current loading of MTEBResults objects. If we do so, we need a solution in the mteb.load_results(), which glues together files based on before loading (which seems slightly frustrating). |
Thanks for looking at this @KennethEnevoldsen! I think this could be trying to sync an older commit perhaps? Did we ever not squash merge? I don't see how HF could say its 10+MB when everything else says 7MB. If it was an intermediate commit which had 10MB+ files it will error like this. We could just remove that commit from this repo |
Ahh, right, that is probably it. Didn't consider that. What is the best approach to resolve this? |
b22bbd7
to
d4cd5e2
Compare
We just had an error on main due to size, but which the tests does not catch