-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run bm25 and ColBERT test in ci #1829
base: v2.0.0
Are you sure you want to change the base?
ci: run bm25 and ColBERT test in ci #1829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only really checks if they can be installed. We should add an actual test as well?
I added two tests in this PR. However, they are not being run in the CI because the dependencies don't exist. |
Ahh thanks for the pointer. Any reason not to remove the skip? (I could later clean up the installs without knowing that I disabled a test). Will you also add a time diff? (coverage report would also be nice, but not required) |
The current issue with PyLate (referenced in GitHub Issue #79) is related to compatibility problems with older Python versions, which is causing the tests for Python 3.9 to fail. Not skipping would require all developers to install additional dependencies: |
Tests conducted on v2.0.0 with Python 3.11: checks occasionally take up to 12 minutes. Performance benchmarks: Test coverage summary: |
I believe I’ve added everything for now and would be happy to get your review of the changes!
|
cI: Enable skipped tests for ColBERT and BM25
fix: get model meta from CrossEncoder
ref: use tmp_path for tests
test: add tests for model_meta
Checklist
make test
.make lint
.start in: #1759 (comment)