resilience and usability

[DBJDBJ]

I have added some simple changes and a lot of comments for proposed further changes.
All aimed at improving the resilience and usability of the cicrcular_buffer.

Please look into the file ...

[phillipjohnston]

@DBJDBJ thank you for your suggestions. I had originally created this class as a simple example, so many of these changes were just left out. However, your suggestions certainly improve the design and mimic the class as I actually use it within my own framework. I will work the changes in along with a new update to the article.

The one area I don't understand is why you use a separate class for SBRM locking of the mutex instead of std::lock_guard.

[phillipjohnston]

Also, for a more complete class I recommend Martin Moene's ring-span-lite, which is similar to the standard proposal for ring-view/ring-span.

[DBJDBJ]

Separate SBRM (as presented) is re-usable. The only reason it is separate.
ring-span-lite is v. good but :) I always start with simple but functional class implemented (not invented) "in the house" .. as a project progresses that is updated accordingly if need to be ... very often this gradually delivers an exact match for the project, v.s. general design and implementation that tries to satisfy "everyone".

It is very likely ring-span-lite (just as an example) will be not a "drop-in replacement" for your circular_buffer ... and time is a scarce resource :)

Good work btw...

[phillipjohnston]

Many improvements are folded in to the circular buffer rewrite