New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

const correctness and explicit constructor #18

Merged

phillipjohnston merged 2 commits into embeddedartistry:master from mpoullet:master

Mar 13, 2018

Contributor

mpoullet commented Mar 13, 2018 •

edited

Loading

Pull Request Template

Description

make const functions member const for better const correctness
make the constructor explicit to prevent implicit conversions

How Has This Been Tested?

By compiling/running circular_buffer.cpp

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

mpoullet added 2 commits

March 13, 2018 13:49


          Make const functions const.

d29a995


          Prevent implicit conversions.

ab135ef

phillipjohnston approved these changes

View reviewed changes

Member

phillipjohnston left a comment

Thanks for your contribution and improvement!

phillipjohnston merged commit 9b1099c into embeddedartistry:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet