Fix misuses read and write pointers #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for W5100 & w5200- reading data should be from the real physical address. but when writting back the new value of REG_S3_RX_RD0, it should be without any manipulation- value should go from 0 to 0xFFFF
for W5100 & w5200- writing data should be from the real physical address. but when writting back the new value of REG_S3_TX_WR0, it should be without any manipulation- value should flow from 0 to 0xFFFF
phillipjohnston
approved these changes
Jan 25, 2022
| #endif | ||
|
|
||
| const unsigned char mDebugMain_TITLE[] PROGMEM = | ||
| TITLE_BOARD_TYPE " (" TITLE_WIZ_TYPE "), Version " PP_STRINGIFY(BUILD_TAG); |
There was a problem hiding this comment.
Really like this new approach!
| @@ -51,17 +51,13 @@ | |||
| #define TFTP_PACKET_MAX_SIZE \ | |||
| (UDP_HEADER_SIZE + TFTP_OPCODE_SIZE + TFTP_BLOCKNO_SIZE + TFTP_MAX_PAYLOAD) | |||
|
|
|||
| #define TFTP_PACKET_DELAY 400 | |||
| #define TFTP_PACKET_DELAY 5 | |||
thx :) regarding the |
|
That's great to know, I filed #91 so we can at least give the option to remove it completely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix misuse of read pointer
REG_S3_RX_RD0& write pointerREG_S3_TX_WR0for WIZnet shields: W5100 & W5200.As a result of this fix,
tftpPollfunction, which processing each new packet, was simplified, and the too-long delay,TFTP_PACKET_DELAY, in each iteration oftftpPollfunction was reduced to 5ms (was 400ms).Fixes #19
Fixes #18
other changes:
MAX_ADDR, of code area fixed to match the makefileType of change
How Has This Been Tested?
see issue #19
Checklist: