This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
Various fixes for sx126x #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasgranberg
approved these changes
Nov 28, 2023
| // SX1261/2 can use optional DC-DC to reduce power usage, | ||
| // but this is related to the hardware implementation of the board. | ||
| if self.config.use_dcdc { | ||
| let reg_data = [OpCode::SetRegulatorMode.value(), RegulatorMode::UseDCDC.value()]; |
There was a problem hiding this comment.
What is the default if regulator mode is not set? Also can we trust the default? Should here be an else clause?
There was a problem hiding this comment.
Default is to use LDO
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its current form it was not really possible to use sx126x