Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stm32/(o|q)spi: command naming convention fix #3661

Merged

Conversation

esden
Copy link
Contributor

@esden esden commented Dec 17, 2024

The naming convention is to prefix blocking functions with blocking. As both command implementations are blocking the async for the ospi implementation should also be dropped.

The naming convention is to prefix blocking functions with blocking. As
both command implementations are blocking the async for the ospi
implementation should also be dropped.
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! :)

@Dirbaio Dirbaio added this pull request to the merge queue Dec 17, 2024
Merged via the queue into embassy-rs:main with commit 341036a Dec 17, 2024
7 checks passed
@esden esden deleted the fix-ospi-n-qspi-command-naming-convention branch December 17, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants