Add support for stm32f4 additional PLL SAI divider #3406
Conversation
I--P
changed the title
embassy-stm32/src/rcc/f247.rs
Outdated
|
|
||
| info!("KAPOUE {}",pllsai.q); |
There was a problem hiding this comment.
something left over from debugging?
There was a problem hiding this comment.
OMG sorry :-)
Should I update my PR for that or will you delete it ?
There was a problem hiding this comment.
No worries, it is your PR you do it.
There was a problem hiding this comment.
you don't have to close the PR to update it, just commit to the branch on your own repo that you are trying to merge. That way the PR updates
There was a problem hiding this comment.
Well, I've not used github for years, I hope I didn't destroy everything, is it ok now ?
There was a problem hiding this comment.
I am not sure if you can do it after you closed the PR, maybe it is possible to re-open? idk
There was a problem hiding this comment.
It's reopened, hopefully it's ok now
| let mut pllsai = init_pll(PllInstance::Pllsai, config.pllsai, &pll_input); | ||
| #[cfg(any(stm32f446, stm32f427, stm32f437, stm32f4x9, stm32f7))] | ||
| RCC.dckcfgr().modify(|w| w.set_pllsaidivq(config.pllsai_divdivq)); | ||
| pllsai.q = match pllsai.q { |
There was a problem hiding this comment.
this could be a map, what is even happening here?
This PR adds support to the second divider of the PLL SAI clock found on stm32f4 boards.
I'm as new to embassy as to rust so this code will certainly not match your coding standards, but at least it works.