RP235x: Add the new FJOIN_RX_xxx options #3369
Draft
+171
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build error can be fixed by depending on pio-rs from this pr: rp-rs/pio-rs#66 |
pferreir
force-pushed
the
add-rxf-putget
branch
from
4ac9fd0 to
46c6476
Compare
pferreir
force-pushed
the
add-rxf-putget
branch
4 times, most recently
from
ce61dcd to
e27918f
Compare
pferreir
force-pushed
the
add-rxf-putget
branch
from
e27918f to
a13f24b
Compare
|
should we wait for rp-rs/pio-rs#66 before merge? I see there's still quite a bit of discussion there. |
|
I think we should wait. It's not clear if the pio-rs pr will need to change more or not. This pr is also out of sync with the current state of that pr. |
|
Removed the |
|
I think this kind of got forgotten. Is this PR still relevant? |
|
afaict it's still waiting on rp-rs/pio-rs#66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires changes in
piotoo if we want the example to work (ping @CBJamo). Probably a new release?