STM32: combine RccPeripherals reset() and enable() to enable_and_reset()

[pbert519]

Close #2034

Combining the standalone functions reset() and enable() into enable_and_reset().

This are a lot of breaking changes, maybe we should add reset_and_enable(), but keep enable() and reset().
And port only the obvious usages.
I'm not able to test everything on real hardware.

[pbert519]

The DAC peripheral has also shared RCC bits for DAC1 und DAC2 in some h7 controllers.
I tried to remove the workaround, however the build.rs script did not generate impl RccPeripherals for DAC1 for the stm32h742xx-cm7 target, all other targets seems to work.
Not sure how to proceed there

[Dirbaio]

Thanks for the PR!

The code should first enable the peripherals then reset them. Reset requires the clocks to be running, otherwise peripheral state can't change. Could you change that, and rename the function?

the build.rs script did not generate impl RccPeripherals for DAC1 for the stm32h742xx-cm7 target, all other targets seems to work.

the data comes from stm32-data. see here, DAC1 is missing the rcc field. Compare with this which is on another chip that does have it.

The code that does the matching is here. There's exceptions hardcoded for ADC, seems DAC needs some too.

(if you want to merge this PR now and fix that later that's fine, this is already a big improvement even if it doesn't fix everything. Up to you!)

[pbert519]

The code should first enable the peripherals then reset them. Reset requires the clocks to be running, otherwise peripheral state can't change. Could you change that, and rename the function?

Done. It's probably better to assume the reset is synchronous. It's a pity that st is not able to define this.

I'll have a look into the DAC topic, but we should split it into a dedicated PR.

[Dirbaio]

could you take these unrelated changes out? thanks!

[pbert519]

This aren't unrelated changes.
While the SAI is only one Peripheral Block, it contains two complety independent subblocks.
Currently it is possible to create a subblock directly, or frist create a SAI peripheral, which just copies the PeripheralRef, so we can initalise both subblocks.
Question, where do we call enable_and_reset()?

This changes force the user to create a SAI first, which enables clock and reset, and then use the take_sub_block to get a SubBlockXPeripheral to initalise the Subblock

[pbert519]

Or in other words: For some Reason ST did not create a SAI1 and SAI2 Peripheral, but only SAI1 which actually contains two independet Peripherals.

[Dirbaio]

ahh got it, makes sense, thank you!

[Dirbaio]

thank you!