-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stm32: add timeout to I2C driver #2033
Conversation
Finally! Made CI happy. I'm not very happy with all the guards everywhere now, but I guess that's what needs to be done? Let me know if you know of better solutions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me! Could you perhaps add at least one chip build to ci.sh that tried to build embassy-stm32 without time so it doesn't bit-rot?
Done |
Unfortunatelly this removed timeout feature from i2c_v1 🫤 |
No description provided.