stm32: add eth tests #1959
Merged
stm32: add eth tests #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bender run |
1 similar comment
|
bender run |
Merged
plaes
reviewed
Sep 28, 2023
| @@ -23,6 +21,10 @@ bind_interrupts!(struct Irqs { | |||
| RNG => embassy_nrf::rng::InterruptHandler<peripherals::RNG>; | |||
| }); | |||
|
|
|||
| // Test-only wifi network, no internet access! | |||
There was a problem hiding this comment.
the tests are hardcoded for the HIL test environment in CI. There's hardcoded chip names, pin numbers, IP addresses too. If someone wants to run the tests on their own they already have to change a lot of stuff anyway, and start up the perf server somewhere in the LAN, etc...
I'm not opposed to make all of that configurable, but it's a substantial effort. Making just the wifi network configurable is not useful if there's still other hardcoded stuff.
(also the wifi network/password was already hardcoded before this PR)
plaes
reviewed
Sep 28, 2023
Dirbaio
force-pushed
the
test-eth
branch
2 times, most recently
from
66705a9 to
9d03414
Compare
Dirbaio
force-pushed
the
test-eth
branch
3 times, most recently
from
6ee4b9e to
680d1c9
Compare
|
bender run |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.