Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STM32] Handle STM32H7 "_C" pins #1895

Closed
wants to merge 7 commits into from

Conversation

JuliDi
Copy link
Contributor

@JuliDi JuliDi commented Sep 13, 2023

As discussed in the chat, the split-pxy features are introduced for use with embassy-rs/stm32-data#254

Ideas for improvement:

  • Verify this actually works with the split functions enabled (the traits are there, but I have no device that actually exposes the PC2/3 pins)
  • Add a testcase / CI step for compilation with these flags. Any suggestions where that should go? Or maybe a HIL test on an H7 board?

@Dirbaio
Copy link
Member

Dirbaio commented Sep 14, 2023

Add a testcase / CI step for compilation with these flags. Any suggestions where that should go?

yes, would be good to add a few test cases of building embassy-stm32 with/without the split-xx features to ci.sh.

Or maybe a HIL test on an H7 board?

perhaps later, since we don't even have ADC hil tests for now...

@JuliDi JuliDi marked this pull request as draft September 15, 2023 08:41
@JuliDi
Copy link
Contributor Author

JuliDi commented Sep 15, 2023

Won't be able to work on this for the next 2 weeks or so, but I'm happy to receive feedback in the meantime and make a proper implementation later on.

@JuliDi JuliDi marked this pull request as ready for review September 27, 2023 19:00
@JuliDi
Copy link
Contributor Author

JuliDi commented Oct 1, 2023

closed in favor of #1988

@JuliDi JuliDi closed this Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants