Skip to content

Commit

Permalink
Remove fixmes that no longer apply
Browse files Browse the repository at this point in the history
  • Loading branch information
bugadani committed Dec 10, 2024
1 parent b4b3595 commit cd963b3
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions embassy-executor/src/raw/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -621,9 +621,6 @@ pub fn wake_task(task: TaskRef) {
let header = task.header();
if header.state.run_enqueue() {
// We have just marked the task as scheduled, so enqueue it.
// FIXME: there is currently a data race between re-spawning a task and waking it using an
// old waker. If the task is being spawned on a different executor, then reading and writing
// the executor field may happen concurrently.
unsafe {
let executor = header.executor.get().unwrap_unchecked();
executor.enqueue(task);
Expand All @@ -638,9 +635,6 @@ pub fn wake_task_no_pend(task: TaskRef) {
let header = task.header();
if header.state.run_enqueue() {
// We have just marked the task as scheduled, so enqueue it.
// FIXME: there is currently a data race between re-spawning a task and waking it using an
// old waker. If the task is being spawned on a different executor, then reading and writing
// the executor field may happen concurrently.
unsafe {
let executor = header.executor.get().unwrap_unchecked();
executor.run_queue.enqueue(task);
Expand Down

0 comments on commit cd963b3

Please sign in to comment.