feat: handle client errors correctly

emartech · Feb 23, 2018 · 4ac114c · 4ac114c
1 parent 5319e6c
commit 4ac114c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/session_validator/client.rb b/lib/session_validator/client.rb
@@ -31,7 +31,7 @@ def valid?(msid)
 
       log Logger::DEBUG, "response code: #{response.code}, response body: #{response.body}"
 
-      !response.is_a? Net::HTTPNotFound
+      response.is_a? Net::HTTPSuccess or response.is_a? Net::HTTPServerError
     rescue Net::OpenTimeout
       log Logger::DEBUG, "open timeout"
       true

diff --git a/spec/session_validator/client_spec.rb b/spec/session_validator/client_spec.rb
@@ -46,6 +46,12 @@
       it { is_expected.to eq false }
     end
 
+    context "client is not configured properly" do
+      before { http_request.to_return status: [401, "Unauthorized"] }
+
+      it { is_expected.to eq false }
+    end
+
     context "service is not working properly" do
       before { http_request.to_return status: [500, "Internal Server Error"] }