Use boolean

emanuele-scarsella · Oct 1, 2023 · 0df3ad0 · 0df3ad0
1 parent ba3b1cc
commit 0df3ad0
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 12 deletions.
diff --git a/.github/workflows/linux-new.yml b/.github/workflows/linux-new.yml
@@ -34,7 +34,8 @@ on:
       uploadRelease:
         description: "upload binaries to releases, otherwise only upload via artifact"
         required: false
-        default: ""
+        type: boolean
+        default: false
   workflow_call:
     inputs:
       flavors:
@@ -75,8 +76,8 @@ on:
       uploadRelease:
         description: "upload binaries to releases, otherwise only upload via artifact"
         required: false
-        type: string
-        default: ""
+        type: boolean
+        default: false
 
 jobs:
   gen-jobs:
@@ -95,7 +96,7 @@ jobs:
               throw new ErrorException($message, 0, $severity, $file, $line);
           });
 
-          if (!!'${{ github.event.inputs.uploadRelease }}') {
+          if (${{ github.event.inputs.uploadRelease }}) {
               # create github release
               echo "create release\n";
 

diff --git a/.github/workflows/macos-new.yml b/.github/workflows/macos-new.yml
@@ -30,7 +30,8 @@ on:
       uploadRelease:
         description: "upload binaries to releases, otherwise only upload via artifact"
         required: false
-        default: ""
+        type: boolean
+        default: false
   workflow_call:
     inputs:
       flavors:
@@ -66,8 +67,8 @@ on:
       uploadRelease:
         description: "upload binaries to releases, otherwise only upload via artifact"
         required: false
-        type: string
-        default: ""
+        type: boolean
+        default: false
 
 jobs:
   gen-jobs:
@@ -86,7 +87,7 @@ jobs:
               throw new ErrorException($message, 0, $severity, $file, $line);
           });
 
-          if (!!'${{ github.event.inputs.uploadRelease }}') {
+          if (${{ github.event.inputs.uploadRelease }}) {
               # create github release
               echo "create release\n";
 

diff --git a/.github/workflows/windows-new.yml b/.github/workflows/windows-new.yml
@@ -30,7 +30,8 @@ on:
       uploadRelease:
         description: "upload binaries to releases, otherwise only upload via artifact"
         required: false
-        default: ""
+        type: boolean
+        default: false
   workflow_call:
     inputs:
       flavors:
@@ -66,8 +67,8 @@ on:
       uploadRelease:
         description: "upload binaries to releases, otherwise only upload via artifact"
         required: false
-        type: string
-        default: ""
+        type: boolean
+        default: false
 
 jobs:
   gen-jobs:
@@ -86,7 +87,7 @@ jobs:
               throw new ErrorException($message, 0, $severity, $file, $line);
           });
 
-          if (!!'${{ github.event.inputs.uploadRelease }}') {
+          if (${{ github.event.inputs.uploadRelease }}) {
               # create github release
               echo "create release\n";