Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readme a bit #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mmagnus
Copy link

@mmagnus mmagnus commented May 21, 2020

No description provided.


(require 'grammarly)
(require 'flycheck-grammarly)
(add-hook 'markdown-mode-hook 'flyspell-grammarly)
Copy link
Member

@jcs090218 jcs090218 May 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I don't think you need (require' grammarly) and the add-hook, like what I have explain here. #1 (comment). Maybe just leave require flycheck-grammarly?

@jcs090218
Copy link
Member

jcs090218 commented Jun 9, 2020

Any idea from my comment and review? 😕 Thanks! :)

@appetrosyan
Copy link

I would suggest clarifying that this doesn’t require a grammarly premium account.

I would also have it set up using use-package, as this is common-enough to be helpful. In fact this would make the dependency on grammarly Explicit.

@jcs090218 jcs090218 added the documentation Improvements or additions to documentation label Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants