v1.0 last call #674
Merged
v1.0 last call #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bdarcus, if we're okay with the performance, I don't think we have to hold up 1.0. We can always make another point release later that'll improve matters for people with large bibliographies. I don't think there's going to be any API change anyway. |
|
Sounds good. I'll still wait until tomorrow to see if Joost pushes any commits to address that. EDIT: actually, I'll probably wait to Monday. There's no rush, and we don't want a bug report for something we know is an issue. I also have a Doom biblio module bump ready to go, but waiting for the same reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm planning to merge this and then tag 1.0 "very soon"; ideally once Joost has a chance to improve performance of #659 a bit, and I can bump parsebib to 4.3 instead.
If any last minute changes, @roshanshariff, you can add them here, though I think we're good.
Edit: seeing your latest message, can also hold off until the weekend if you prefer. Just want to get this off my TODO list in the next few days.
If you do want to add a more substantial commit, you can also just do that, and I can then rebase on main.