heap-use-after-free after using scroll of food detection. Fixes #486

elunna · Sep 27, 2023 · dfbdd3b · dfbdd3b
1 parent 41f3fa3
commit dfbdd3b
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/read.c b/src/read.c
@@ -2278,7 +2278,8 @@ struct obj *sobj; /* sobj - scroll or fake spellbook for spell */
     case SPE_DETECT_FOOD: {
         boolean failure;
         failure = (food_detect(sobj) != 0);
-        if (!failure && sobj && sobj->blessed && monster_detect(sobj, S_BAD_FOOD))
+        if (!failure && sobj && sobj->blessed
+              && (monster_detect(sobj, S_BAD_FOOD)== 0))
             failure = FALSE;
         if (failure) {
             sobj = 0; /* failure: strange_feeling() -> useup() */