Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency babel-eslint to v10 #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Aug 10, 2019

This PR contains the following updates:

Package Type Update Change
babel-eslint devDependencies major 8.2.6 -> 10.0.3

Release Notes

babel/babel-eslint

v10.0.3

Compare Source

Fixes #​791, also eslint/eslint#​12117

Some context: #​793 (comment)

We ended up going with @​JLHwung's PR #​794 which uses ESLint's deps instead of going with peerDeps since it really depends on the version being used and we don't want users to have to install it directly on their own.

babel-eslint is patching patches of the dependencies of ESLint itself so these kinds of issues have happened in the past. We'll need to look into figuring out how to have a more solid way of modifying behavior instead of this monkeypatching type of thing for future releases.

v10.0.2

Compare Source

Fixes #​772

v10.0.1

Compare Source

v10.0.1

The TypeAlias "conversion" to a function has issues. Sounds like we need to rethink the change, most likely we can just actually change the scoping rather than hardcode an AST change.

v10.0.0

Compare Source

v10.0.0

Small breaking change: add a peerDependency starting from the ESLint version that added a parser feature that we were monkeypatching before (and drop that code). If already using ESLint 5 shouldn't be any different.

/* @​flow */
type Node<T> = { head: T; tail: Node<T> }

// or 

type File = {chunks: Array<Chunk>}
type Chunk = {file: File}
  • Update to test against ESLint 5, add a peerDependency: #​689
  • Drop monkeypatching behavior: #​690

v9.0.0

Compare Source

v9.0.0

We've released v7: https://twitter.com/left_pad/status/1034204330352500736, so this just updates babel-eslint to use those versions internally. That in itself doesn't break anything but:

  • Babel now supports the new decorators proposal by default, so we need to switch between the new and the old proposal. This is a breaking change.

To enable the legacy decorators proposal users should add a specific parser option:

{
  parserOptions: {
    ecmaFeatures: {
      legacyDecorators: true
    }
  }
}
  • Babel removed the support for Node 4 , so I propagated that here.

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot force-pushed the renovate/major-babel-monorepo branch from 1cf32dc to c4cd138 Compare September 5, 2019 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant