fix: broken subscription update query (#431)

ellite · Jul 8, 2024 · b00a985 · b00a985
1 parent 38fb3e0
commit b00a985
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/endpoints/subscription/add.php b/endpoints/subscription/add.php
@@ -198,19 +198,16 @@ function resizeAndUploadLogo($uploadedFile, $uploadDir, $name, $settings)
                 $sql = "UPDATE subscriptions SET name = :name, logo = :logo, price = :price, currency_id = :currencyId,
                      next_payment = :nextPayment, cycle = :cycle, frequency = :frequency, notes = :notes, payment_method_id = :paymentMethodId,
                      payer_user_id = :payerUserId, category_id = :categoryId, notify = :notify, inactive = :inactive, 
-                     url = :url, notify_days_before = :notifyDaysBefore, camcelation_date = :cancellationDate WHERE id = :id AND user_id = :userId";
+                     url = :url, notify_days_before = :notifyDaysBefore, cancellation_date = :cancellationDate WHERE id = :id AND user_id = :userId";
             } else {
-                $sql = "UPDATE subscriptions SET name = :name, price = :price, currency_id = :currencyId, next_payment = :nextPayment,
-                    cycle = :cycle, frequency = :frequency, notes = :notes, payment_method_id = :paymentMethodId, payer_user_id = :payerUserId,
-                    category_id = :categoryId, notify = :notify, inactive = :inactive, url = :url, notify_days_before = :notifyDaysBefore, 
-                    cancellation_date = :cancellationDate WHERE id = :id AND user_id = :userId";
+                $sql = "UPDATE subscriptions SET name = :name, price = :price, currency_id = :currencyId,
+                     next_payment = :nextPayment, cycle = :cycle, frequency = :frequency, notes = :notes, payment_method_id = :paymentMethodId,
+                     payer_user_id = :payerUserId, category_id = :categoryId, notify = :notify, inactive = :inactive, 
+                     url = :url, notify_days_before = :notifyDaysBefore, cancellation_date = :cancellationDate WHERE id = :id AND user_id = :userId";
             }
         }
 
         $stmt = $db->prepare($sql);
-        if ($isEdit) {
-            $stmt->bindParam(':id', $id, SQLITE3_INTEGER);
-        }
         $stmt->bindParam(':name', $name, SQLITE3_TEXT);
         if ($logo != "") {
             $stmt->bindParam(':logo', $logo, SQLITE3_TEXT);
@@ -228,8 +225,11 @@ function resizeAndUploadLogo($uploadedFile, $uploadDir, $name, $settings)
         $stmt->bindParam(':inactive', $inactive, SQLITE3_INTEGER);
         $stmt->bindParam(':url', $url, SQLITE3_TEXT);
         $stmt->bindParam(':notifyDaysBefore', $notifyDaysBefore, SQLITE3_INTEGER);
-        $stmt->bindParam(':userId', $userId, SQLITE3_INTEGER);
         $stmt->bindParam(':cancellationDate', $cancellationDate, SQLITE3_TEXT);
+        if ($isEdit) {
+            $stmt->bindParam(':id', $id, SQLITE3_INTEGER);
+        }
+        $stmt->bindParam(':userId', $userId, SQLITE3_INTEGER);
 
         if ($stmt->execute()) {
             $success['status'] = "Success";

diff --git a/includes/version.php b/includes/version.php
@@ -1,3 +1,3 @@
 <?php
-$version = "v2.14.1";
+$version = "v2.14.2";
 ?>