fix: calling htmlspecialchars_decode on null objects (#338)

ellite · May 20, 2024 · 5050a28 · 5050a28
1 parent 9e8b84b
commit 5050a28
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/endpoints/subscription/get.php b/endpoints/subscription/get.php
@@ -13,20 +13,20 @@
 
             if ($row = $result->fetchArray(SQLITE3_ASSOC)) {
                 $subscriptionData['id'] = $subscriptionId;
-                $subscriptionData['name'] = htmlspecialchars_decode($row['name']);
+                $subscriptionData['name'] = htmlspecialchars_decode($row['name'] ?? "");
                 $subscriptionData['logo'] = $row['logo'];
                 $subscriptionData['price'] = $row['price'];
                 $subscriptionData['currency_id'] = $row['currency_id'];
                 $subscriptionData['next_payment'] = $row['next_payment'];
                 $subscriptionData['frequency'] = $row['frequency'];
                 $subscriptionData['cycle'] = $row['cycle'];
-                $subscriptionData['notes'] = htmlspecialchars_decode($row['notes']);
+                $subscriptionData['notes'] = htmlspecialchars_decode($row['notes'] ?? "");
                 $subscriptionData['payment_method_id'] = $row['payment_method_id'];
                 $subscriptionData['payer_user_id'] = $row['payer_user_id'];
                 $subscriptionData['category_id'] = $row['category_id'];
                 $subscriptionData['notify'] = $row['notify'];
                 $subscriptionData['inactive'] = $row['inactive'];
-                $subscriptionData['url'] = htmlspecialchars_decode($row['url']);
+                $subscriptionData['url'] = htmlspecialchars_decode($row['url'] ?? "");
                 $subscriptionData['notify_days_before'] = $row['notify_days_before'];
 
                 $subscriptionJson = json_encode($subscriptionData);

diff --git a/endpoints/subscriptions/get.php b/endpoints/subscriptions/get.php
@@ -76,7 +76,7 @@
           $id = $subscription['id'];
           $print[$id]['id'] = $id;
           $print[$id]['logo'] = $subscription['logo'] != "" ? "images/uploads/logos/".$subscription['logo'] : $defaultLogo;
-          $print[$id]['name'] = htmlspecialchars_decode($subscription['name']);
+          $print[$id]['name'] = htmlspecialchars_decode($subscription['name'] ?? ""); 
           $cycle = $subscription['cycle'];
           $frequency = $subscription['frequency'];
           $print[$id]['billing_cycle'] = getBillingCycle($cycle, $frequency, $i18n);
@@ -92,8 +92,8 @@
           $print[$id]['payer_user_id'] = $subscription['payer_user_id'];
           $print[$id]['price'] = floatval($subscription['price']);
           $print[$id]['inactive'] = $subscription['inactive'];
-          $print[$id]['url'] = htmlspecialchars_decode($subscription['url']);
-          $print[$id]['notes'] = htmlspecialchars_decode($subscription['notes']);
+          $print[$id]['url'] = htmlspecialchars_decode($subscription['url'] ?? "");
+          $print[$id]['notes'] = htmlspecialchars_decode($subscription['notes'] ?? "");
 
           if (isset($settings['convertCurrency']) && $settings['convertCurrency'] === 'true' && $currencyId != $mainCurrencyId) {
             $print[$id]['price'] = getPriceConverted($print[$id]['price'], $currencyId, $db);

diff --git a/includes/version.php b/includes/version.php
@@ -1,3 +1,3 @@
 <?php
-    $version = "v1.29.0";
+    $version = "v1.29.1";
 ?>