-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more data when scrapping tweets #2644
base: develop
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @viv-cheung! Welcome to the elizaOS community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now an elizaOS contributor!
Dependency
❗ ❗ Must be merged with : elizaOS/agent-twitter-client#57
Risks
Low
Background
Information like tweet tied to a repost are currently not propagated up, making it impossible to pass this as part of context when building a reply.
What does this PR do?
Adds more information about tweets when scrapping tweets so client can use them, like # of likes, reposts, information about quoted tweet, etc.
What kind of change is this?
Improvements (misc. changes to existing features)
Why are we doing this? Any context or related work?
Very difficult to build a good response to a quote tweet if agents can't access the quoted tweet itself.
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Locally
Where should a reviewer start?
Very small PR, start anywhere
Detailed testing steps
Scrape twitter feed as you always did, but now you have access to more content