feat: register custom service method #2348
Open
+62
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #2315
For example, right now, WebSearchService is defined in a community plugin, not in the core package. As a result, there's no
ServiceType.WEB_SEARCH
norIWebSearchService
in core. This makes it impossible to write code like:outside the plugin, because
IWebSearchService
andWEB_SEARCH
only exist inside the websearch plugin.To work around this, I currently have to add
WEB_SEARCH
andIWebSearchService
to core’s types.ts file. That defeats the purpose of having a decoupled, community-managed plugin.This PR aims to resolve that by allowing external code to create the custom service without needing to modify or depend on core’s enums and interfaces
For example, if I need to call the web search service from the image plugin, I could do: