Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client-slack): implement Media type properties in message attachments #1384 #1741

Merged

Conversation

AIFlowML
Copy link
Collaborator

@AIFlowML AIFlowML commented Jan 3, 2025

Description

This PR fixes issue #1384 by properly implementing the Media type interface for message attachments in the Slack client.

Changes

  • Updated the content object creation in messages.ts to include all required Media type properties
  • Fixed Jest configuration to support ES modules

Testing

  • All tests passing (11/11)
  • Verified proper implementation of Media type interface with required properties:
    • id
    • url
    • title
    • source
    • description
    • text

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related Issues

Fixes #1384

@shakkernerd shakkernerd merged commit 73943a0 into elizaOS:develop Jan 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Slack client Media type implementation missing required properties in message attachments
3 participants