Further clarification to custom expressions in index #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadshaaban92
force-pushed
the
fix-index-column-reserved
branch
from
bc458e6 to
0414fb9
Compare
emadshaaban92
changed the title
josevalim
reviewed
Jun 19, 2024
josevalim
approved these changes
Jun 19, 2024
warmwaffles
reviewed
Jun 19, 2024
Comment on lines
+924
to
+925
| If the expression is a column name, it will not be quoted. This may cause issues | ||
| when the column is named after a reserved word. Consider using an atom instead. |
There was a problem hiding this comment.
Perhaps add a quick example below for the offset problem that was stumbled on?
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #617