Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "GET ../files" #65

Merged
merged 5 commits into from
Sep 26, 2020
Merged

feat: add "GET ../files" #65

merged 5 commits into from
Sep 26, 2020

Conversation

krish8484
Copy link
Contributor

@krish8484 krish8484 commented Sep 22, 2020

Description

  • Endpoint returns ToolFile objects of all files of a tool version associated with a given descriptor
  • All descriptor, test and "other" files (all files except CONTAINERFILEs) are required to be associated with a descriptor type (e.g., NFL, CWL) and pointers are returned via this endpoint (to be retrieved via GET /tools/{id}/versions/{version_id}/{type}/descriptor/{relative_path})
  • Support for application/zip response not yet implemented

Fixes #28

@krish8484
Copy link
Contributor Author

All of the things in this PR has been implemented and tested except one. I was not sure of how exactly we want the application/zippart, therefore I couldn't implement it. Everything else apart from application/zip looks OK locally.

@krish8484 krish8484 requested a review from uniqueg September 22, 2020 08:21
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was a really good start. Unfortunately found some issue with the schema so needed some refactoring. Also decided to go with the more standard requests package to handle the calls to retrieve content. This will need some work in the future as it's a potential security risk and also all kinds of things can go wrong (file ends up to be huuuuge, not a text file, connection times out etc...). But for now, where we'll manually get the files in and can double check that all will be fine, it should be good enough

@uniqueg uniqueg merged commit f069b00 into dev Sep 26, 2020
@uniqueg uniqueg deleted the get_files branch September 26, 2020 17:52
@uniqueg uniqueg changed the title feat:Add get ../files support feat: add "GET ../files" support Oct 1, 2020
@uniqueg uniqueg changed the title feat: add "GET ../files" support feat: add "GET ../files" Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement "GET .../files" endpoint
2 participants