Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create server instance using constructor, use interface-based logger #170

Merged
merged 6 commits into from
Mar 15, 2024

Conversation

icamys
Copy link
Contributor

@icamys icamys commented Mar 13, 2024

This is a PR for the elimity-com:qol branch that proposes additional modifications to the logger usage and server construction:

  • Pass logger to the server via the interface
  • Add a noop logger implementation
  • Make the logger instance a part of the server instead of a global variable
  • Use functional options to build server instance
  • Make the error handler a part of the server to allow logger usage

@icamys icamys mentioned this pull request Mar 13, 2024
server.go Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@icamys icamys requested a review from q-uint March 13, 2024 16:10
Copy link
Contributor Author

@icamys icamys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@q-uint The updated constructor is there. Please take a look when you have a spare minute.

Copy link
Collaborator

@q-uint q-uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@q-uint
Copy link
Collaborator

q-uint commented Mar 15, 2024

@icamys, I'll merge this with the QOL branch, and fix the final NITs there. Thanks for adding this!

@q-uint q-uint merged commit f417b10 into elimity-com:qol Mar 15, 2024
3 of 4 checks passed
@icamys icamys deleted the feat/interface-logger branch March 20, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants